RE: [PATCH] Fix for issue 2753 "SVNListParentPath feature doesn't work when svn authz is used."
From: Kamesh Jayachandran <kamesh_at_collab.net>
Date: Fri, 9 Apr 2010 00:18:51 +0530
Thanks for the review Philip.
>Let me see if I understand: The issue is that when SVNListParentPath
>Your patch recognises this request and avoids doing the authz check.
>> + canonicalized_uri = svn_uri_canonicalize(r->uri, r->pool);
>Can conf->base_path be canonicalised once in
Yes should be, Will update my patch to handle this.
>> + if (strcmp(canonicalized_uri, canonicalized_root_path) == 0)
>What happens if SVNParentPath is not being used? Is base_path is the
I tested this
$svn co http://localhost/svn <-- Repo itself instead of parent of repositories.
>I think this check would make more sense in access_checker rather than
Let me see and do if needed.
>The code needs a comment to say why no access control is neccessary in
Will update the comment.
This is an archived mail posted to the Subversion Dev mailing list.