[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

RE: svn commit: r931209 - /subversion/trunk/subversion/libsvn_ra/ra_loader.c

From: Bert Huijben <bert_at_qqmail.nl>
Date: Wed, 7 Apr 2010 11:17:09 +0200

> -----Original Message-----
> From: cmpilato_at_apache.org [mailto:cmpilato_at_apache.org]
> Sent: dinsdag 6 april 2010 18:25
> To: commits_at_subversion.apache.org
> Subject: svn commit: r931209 -
> /subversion/trunk/subversion/libsvn_ra/ra_loader.c
>
> Author: cmpilato
> Date: Tue Apr 6 16:25:21 2010
> New Revision: 931209
>
> URL: http://svn.apache.org/viewvc?rev=931209&view=rev
> Log:
> Add compat code to work around pre-1.7 servers' messy handling of
> mergeinfo paths.
>
> * subversion/libsvn_ra/ra_loader.c
> (svn_ra_get_mergeinfo): Strip leading slashes from catalog keys
> returned by the RA provider.

Shouldn't we handle this in the specific RA layers instead of globally for all ra-layers?

That would allow removing the code for future code paths (like we did for HTTPv2), while this code would hide the issues if we ever reintroduce the bug?

I'm pretty sure you fixed ra_local, so that is at least one ra layer that doesn't need this fix.

        Bert
Received on 2010-04-07 11:17:49 CEST

This is an archived mail posted to the Subversion Dev mailing list.