[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

RE: wc-ng base/working nodes in a copied tree

From: Bert Huijben <bert_at_qqmail.nl>
Date: Wed, 31 Mar 2010 11:41:07 +0200

> -----Original Message-----
> From: Philip Martin [mailto:philip.martin_at_wandisco.com]
> Sent: woensdag 31 maart 2010 11:20
> To: Greg Stein
> Cc: neels; dev_at_subversion.apache.org
> Subject: Re: wc-ng base/working nodes in a copied tree
>
> Greg Stein <gstein_at_gmail.com> writes:
>
> > On Wed, Mar 24, 2010 at 16:41, Philip Martin
> <philip.martin_at_wandisco.com> wrote:
> >> neels <neeels_at_gmail.com> writes:
> >>> On 23 March 2010 09:11, Greg Stein <gstein_at_gmail.com> wrote:
> >>>> On Mon, Mar 22, 2010 at 17:59, Philip Martin
> <philip.martin_at_wandisco.com> wrote:
> >>
> >> We should consider using copyfrom_repos_path. The current method of
> >> only storing copyfrom_* on the root of the copy means that
> >> copyfrom_repos_path needs to be calculated every time its value is
> >> required.
> >
> > I doubt that we use it independently of the other fields, so scanning
> > upwards for the others can also compute the relpath.
> >
> > We do the same thing for the regular repos_id and repos_relpath.
>
> I see there is a comment to that effect in wc-metadata.sql so perhaps
> that was the intent, but in practice repos_id and repos_relpath appear
> to be set in every base_node.

This is mostly caused by the write from entry code, which will disappear before 1.7.

But I expect that we will find quite some code that relies on the data being available anyway. One thing that certainly relies on this is the retrieval of locks via a JOIN with the locks table.

        Bert
Received on 2010-03-31 11:41:43 CEST

This is an archived mail posted to the Subversion Dev mailing list.