[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r929382 - /subversion/branches/1.6.x-wc-ng-error/subversion/libsvn_wc/questions.c

From: Daniel Shahaf <d.s_at_daniel.shahaf.name>
Date: Wed, 31 Mar 2010 09:24:23 +0300 (Jerusalem Daylight Time)

(taking to dev@ from IRC)

peters_at_apache.org wrote on Wed, 31 Mar 2010 at 05:13 -0000:
> On 1.6.x-wc-ng-error branch:
>
> * subversion/libsvn_wc/questions.c
> (is_inside_wc_ng): Ignore errors trying to open wc.db in parent
> directories. Typically this is a filesystem error which has nothing
> to do with wc-ng and everything to do with permissions or similar.
>
...
> +++ subversion/branches/1.6.x-wc-ng-error/subversion/libsvn_wc/questions.c Wed Mar 31 05:13:44 2010
> @@ -62,7 +63,12 @@ is_inside_wc_ng(const char *abspath,
>
> wc_db_path = svn_path_join_many(pool, abspath, SVN_WC_ADM_DIR_NAME,
> "wc.db", NULL);

Shouldn't this use svn_wc_get_adm_dir()?

> - SVN_ERR(svn_io_check_path(wc_db_path, &kind, pool));
> + err = svn_io_check_path(wc_db_path, &kind, pool);
> + if (err)
> + {
> + svn_error_clear(err);
> + return SVN_NO_ERROR;
> + }
>

Given the rationale (in the log message), do we want to ignore *any*
errors here? Or only errors related to (for example) permissions.

(Note that the ../../../.svn/wc.db accessed here may be anywhere, above
or below one's home dir, etc.)

> if (kind == svn_node_file)
> {
>
>
>
Received on 2010-03-31 08:24:22 CEST

This is an archived mail posted to the Subversion Dev mailing list.