[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

redundant path functions

From: Greg Stein <gstein_at_gmail.com>
Date: Tue, 30 Mar 2010 20:46:51 -0400

The following functions seem very redundant. Because each is slightly
different, I always have to compare/contrast them to isolate their
differences. It would be much better if we could pick JUST ONE, and
run with that:

svn_*_is_child()
svn_*_is_ancestor()
svn_*_skip_ancestor()

I do realize that we published the svn_dirent_* functions in 1.6, but
we don't have to carry their analogues to the new functions. (and
possibly even deprecate the 1.6 funcs)

It seems that the is_child variant is the only function needed. The
is_ancestor() is merely is_child() != NULL, and the skip_ancestor is
simply pool=NULL.

Am I missing something, and/or can/should we remove this redundancy?

Cheers,
-g
Received on 2010-03-31 02:47:18 CEST

This is an archived mail posted to the Subversion Dev mailing list.