[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r928299 - /subversion/trunk/subversion/libsvn_wc/update_editor.c

From: Greg Stein <gstein_at_gmail.com>
Date: Sun, 28 Mar 2010 09:30:33 -0400

Simplify the call sites (the entire point!). eb is way shorter than the two
de-refs. I did think about it tho, and settled with constifying eb.

I wouldn't be strongly opposed to changing it, but it would be significantly
longer.

On Mar 27, 2010 9:46 PM, "Hyrum K. Wright" <hyrum_wright_at_mail.utexas.edu>
wrote:

On Mar 27, 2010, at 6:04 PM, gstein_at_apache.org wrote:

> Author: gstein
> Date: Sat Mar 27 23:04:28...
Why pass the entire edit baton here? You're only using the notify_func and
notify_baton.

> + const char *local_abspath,
> + svn_node_kind_t kind,
> + ...
...

-Hyrum
Received on 2010-03-28 15:31:02 CEST

This is an archived mail posted to the Subversion Dev mailing list.