Philip Martin wrote:
> rdonch_at_apache.org writes:
>
> > Author: rdonch
> > Date: Wed Mar 24 22:39:24 2010
> > New Revision: 927211
> >
> > URL: http://svn.apache.org/viewvc?rev=927211&view=rev
> > Log:
> > * subversion/libsvn_wc/wc_db.c:
> > (svn_wc__db_wclock_set): Pass levels_to_lock to svn_sqlite__bindf
> > as a 64-bit value, as required by the latter.
> >
> >
> > Modified:
> > subversion/trunk/subversion/libsvn_wc/wc_db.c
> >
> > Modified: subversion/trunk/subversion/libsvn_wc/wc_db.c
> > URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/libsvn_wc/wc_db.c?rev=927211&r1=927210&r2=927211&view=diff
> > ==============================================================================
> > --- subversion/trunk/subversion/libsvn_wc/wc_db.c (original)
> > +++ subversion/trunk/subversion/libsvn_wc/wc_db.c Wed Mar 24 22:39:24 2010
> > @@ -6068,7 +6068,7 @@ svn_wc__db_wclock_set(svn_wc__db_t *db,
> > SVN_ERR(svn_sqlite__get_statement(&stmt, pdh->wcroot->sdb,
> > STMT_INSERT_WC_LOCK));
> > SVN_ERR(svn_sqlite__bindf(stmt, "isi", pdh->wcroot->wc_id, local_relpath,
> > - levels_to_lock));
> > + (apr_int64_t) levels_to_lock));
> > err = svn_sqlite__insert(NULL, stmt);
> > if (err)
> > return svn_error_createf(SVN_ERR_WC_LOCKED, err,
>
> Make the levels_to_lock parameter in svn_wc__db_wclock_set an
> apr_int64_t and the compiler will automatically convert and the cast
> would be unnecessary.
But that would obscure the reason for it and "int levels_to_lock" is the
API idiom throughout Subversion. Although casts are to be avoided when
possible, it's better to keep this impl detail as an impl detail so it's
clear why it's there.
- Julian
Received on 2010-03-25 11:25:17 CET