[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Constifying patches break bindings

From: Julian Foad <julian.foad_at_wandisco.com>
Date: Tue, 23 Mar 2010 15:21:16 +0000

Adding 'const' to the pointer arguments of function _typedefs_ is an
API-incompatible change, and so I shall revert those parts of my r922239
commit.

I can't see any buildbot results that were affected by that commit,
however.
(<http://crest.ics.uci.edu/buildbot/waterfall?last_time=1268420000>
shows no change in results at r922239.)

- Julian

On Tue, 2010-03-23 at 14:43 +0100, Bert Huijben wrote:
> Posted to dev@, in an attempt to get the buildbots green again:
>
>
>
> (Yesterday evening; times in CET / UTC+1)
>
>
>
> 22:20 < CIA-77> rdonch * r926343 /trunk/subversion/bindings/swig/svn_diff.i:
> * subversion/bindings/swig/svn_diff.i:
>
> Immutablize some struct members, ...
>
> 22:27 <@Bert> RDonch: Does this fix the buildbots?
>
> 22:28 < RDonch> Bert: almost.
>
> <snip>
>
> 22:31 <@Bert> RDonch: It fails on the x64-ubuntu-gcc bot.. But it looks like
> the centos bot gets further than before
>
> 22:31 < RDonch> julianf: in r922239 you add a bunch of const qualifiers and
> say that it's a backwards-compatible change
>
> - but is it? E.g. a function that was a
> svn_ra_file_rev_handler_t will no longer be, causing compiler
>
> errors.
>
> 22:31 < RDonch> Bert: ^ this is the remaining failure.
>
>
>
>
>
Received on 2010-03-23 16:21:51 CET

This is an archived mail posted to the Subversion Dev mailing list.