Re: [PATCH] Allow "cease invocation" return from Python callback for repos.svn_repos_history2()

Alexey Neyman <stilor_at_att.net> писал в своём письме Fri, 19 Mar 2010
02:26:28 +0300:

>> Hmm. How are you testing this? I'd write a test script, but I'm short
>> on time, and you probably already have one. 8=]
>
> Yes, please use the attached pre-commit script. Then:

> ...

>
> Changed to the following code (difference from previous version is that
> it
> Py_DECREF's everything):

> ...

> if (PyErr_GivenExceptionMatches(exc_class, err))

I will investigate more carefully later, but you've got this the wrong way
around. The exception should be the first argument, and the class should
be the second. The doc for PyErr_GivenExceptionMatches is kind of
ambiguous, but see the doc for PyErr_ExceptionMatches.

> ...

Roman.
Received on 2010-03-19 01:31:55 CET