[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r924722 - in /subversion/trunk/subversion: include/svn_wc.h libsvn_client/switch.c libsvn_client/update.c libsvn_wc/deprecated.c libsvn_wc/update_editor.c

From: Greg Stein <gstein_at_gmail.com>
Date: Thu, 18 Mar 2010 17:21:24 -0400

On Thu, Mar 18, 2010 at 07:34, <julianfoad_at_apache.org> wrote:
> Author: julianfoad
> Date: Thu Mar 18 11:34:45 2010
> New Revision: 924722
>
> URL: http://svn.apache.org/viewvc?rev=924722&view=rev
> Log:
> Clean up two revved WC API function signatures: move the wc_ctx parameter
> before the first of the main input parameters, to keep those together and
> to minimize the difference from the previous version.  Do some doc string
> clean-ups too.
>
> * subversion/include/svn_wc.h
>  (svn_wc_get_status_editor5): Fix a parameter name typo. Note doc string
>    out-of-dateness.
>  (svn_wc_crawl_revisions5): Note doc string out-of-dateness.
>  (svn_wc_get_update_editor4): Swap revision and wc_ctx parameters.
>  (svn_wc_get_switch_editor4): Swap revision and wc_ctx parameters. Refer to
>    svn_wc_get_update_editor4's doc string for most parameters to make it
>    easy for the reader to see that there are no differences.

Why swap these parameters? REVISION (or TARGET_REVISION) is an OUT
parameter. We always place OUT parameters first, and then the WC_CTX,
then the other params.

>...

Cheers,
-g
Received on 2010-03-18 22:21:52 CET

This is an archived mail posted to the Subversion Dev mailing list.