[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r919460 - filtering svn patch targets

From: Stefan Sperling <stsp_at_elego.de>
Date: Thu, 18 Mar 2010 13:24:43 +0100

On Sat, Mar 13, 2010 at 09:41:06AM +0100, Stefan Sperling wrote:
> On Fri, Mar 12, 2010 at 11:12:38PM -0800, Joe Swatosh wrote:
> > On Fri, Mar 12, 2010 at 1:45 AM, Stefan Sperling <stsp_at_elego.de> wrote:
> > > On Fri, Mar 12, 2010 at 03:11:06AM +0100, Neels J Hofmeyr wrote:
> > >> Stefan Sperling wrote:
> > >> >>> What is not possible (without adding the --include-pattern option)
> >
> > >
> > > It does. You can manually revert the edits 'svn patch' made to the file.
> > > Whether this is feasible or not really depends on the kind of modifications
> > > the user and the patch are making. But it seems to me like the tortoise
> > > GUI was designed around the assumption that users will often want to
> > > apply only parts of patches at file-level granularity. I don't believe
> > > that this is what people do in reality, so I'm questioning this GUI
> > > design because it has repercussions on the svn patch API.
> > > (I didn't really think about this before working on fixing #3434
> > > unfortunately.)
> > >
> >
> > Speaking up as a user of TortoiseSVN here, I use this several times a
> > week at work.
>
> OK, great then. So people need this.
>
> That means that I'll eventually add an --include-patterns option to the
> CLI client. I don't see the point of having a libsvn_client API that
> tortoiseSVN uses to provide a useful feature, but have the CLI client
> not expose this useful feature.

The --include-pattern option now exists as of r924737.

We may still decide to rename the --include-pattern/--exclude-pattern
options of the svn command line client before 1.7.0 release, but the
API for including/excluding patch targets will most likely stay as is.

Stefan
Received on 2010-03-18 13:25:43 CET

This is an archived mail posted to the Subversion Dev mailing list.