[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r924260 - /subversion/trunk/subversion/libsvn_wc/adm_ops.c

From: Greg Stein <gstein_at_gmail.com>
Date: Wed, 17 Mar 2010 15:00:13 -0400

On Wed, Mar 17, 2010 at 08:29, <cmpilato_at_apache.org> wrote:
>...
> +++ subversion/trunk/subversion/libsvn_wc/adm_ops.c Wed Mar 17 12:29:14 2010
> @@ -582,22 +582,21 @@ svn_wc__prop_array_to_hash(const apr_arr
>                            apr_pool_t *result_pool)
>  {
>   int i;
> -  apr_hash_t *dav_cache;
> +  apr_hash_t *prophash;
>
>   if (props == NULL || props->nelts == 0)
>     return NULL;
>
> -  dav_cache = apr_hash_make(result_pool);
> +  prophash = apr_hash_make(result_pool);
>
>   for (i = 0; i < props->nelts; i++)
>     {
>       const svn_prop_t *prop = APR_ARRAY_IDX(props, i, const svn_prop_t *);
> -
>       if (prop->value != NULL)

Style nit: please don't remove blank lines that end up smashing code
against the declaration block. It then becomes very difficult to
distinguish the two.

(obviously, no need to go back to add this, but please don't keep
doing this....)

>...

Cheers,
-g
Received on 2010-03-17 20:00:50 CET

This is an archived mail posted to the Subversion Dev mailing list.