[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

RE: svn commit: r922511 - /subversion/trunk/subversion/libsvn_client/commit.c

From: Bert Huijben <bert_at_qqmail.nl>
Date: Sun, 14 Mar 2010 17:32:21 +0100

> -----Original Message-----
> From: philip_at_apache.org [mailto:philip_at_apache.org]
> Sent: zaterdag 13 maart 2010 10:27
> To: commits_at_subversion.apache.org
> Subject: svn commit: r922511 -
> /subversion/trunk/subversion/libsvn_client/commit.c
>
> Author: philip
> Date: Sat Mar 13 09:27:20 2010
> New Revision: 922511
>
> URL: http://svn.apache.org/viewvc?rev=922511&view=rev
> Log:
> Remove access batons from client commit code.
>
> * subversion/libsvn_client/commit.c
> (struct check_dir_delete_baton): Remove access baton.
> (check_nonrecursive_dir_delete): Check locks instead of access
> batons.
> (svn_client_commit4): Acquire and release locks instead of access
> batons.

Since this patch the fsfs x svn buildbot reports:
FAIL: commit_tests.py 27: committing two WCs from different repos fails
(The other RA layers don't)

CMD: svn commit -m log svn-test-work/working_copies/commit_tests-27/wc1 svn-test-work/working_copies/commit_tests-27/wc2 --config-dir /home/svnbuilder/slave/eh-debsarge1/build/subversion/tests/cmdline/svn-test-work/local_tmp/config --password rayjandom --no-auth-cache --username jrandom
CMD: /home/svnbuilder/slave/eh-debsarge1/build/subversion/svn/svn commit -m log svn-test-work/working_copies/commit_tests-27/wc1 svn-test-work/working_copies/commit_tests-27/wc2 --config-dir /home/svnbuilder/slave/eh-debsarge1/build/subversion/tests/cmdline/svn-test-work/local_tmp/config --password rayjandom --no-auth-cache --username jrandom exited with 1
<TIME = 0.019760>
subversion/svn/commit-cmd.c:142: (apr_err=155004)
subversion/libsvn_client/commit.c:1172: (apr_err=155004)
subversion/libsvn_client/commit.c:1028: (apr_err=155004)
svn: Are all targets part of the same working copy?
svn: run 'svn cleanup' to remove locks (type 'svn help cleanup' for details)
Expected output on stderr doesn't match
EXPECTED STDERR (regexp):
.*is not a working copy.*
ACTUAL STDERR:
subversion/svn/commit-cmd.c:142: (apr_err=155004)
subversion/libsvn_client/commit.c:1172: (apr_err=155004)
subversion/libsvn_client/commit.c:1028: (apr_err=155004)
svn: Are all targets part of the same working copy?
svn: run 'svn cleanup' to remove locks (type 'svn help cleanup' for details)
EXCEPTION: SVNUnmatchedError

        Bert
Received on 2010-03-14 17:33:08 CET

This is an archived mail posted to the Subversion Dev mailing list.