[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r921916 - in /subversion/trunk/subversion: libsvn_repos/fs-wrap.c libsvn_repos/load.c svn/status-cmd.c

From: Julian Foad <julian.foad_at_wandisco.com>
Date: Thu, 11 Mar 2010 23:53:17 +0000

On Thu, 2010-03-11, Greg Stein wrote:
> On Thu, Mar 11, 2010 at 11:13, <julianfoad_at_apache.org> wrote:
> >...
> > +++ subversion/trunk/subversion/libsvn_repos/load.c Thu Mar 11 16:13:39 2010
> > @@ -279,8 +279,8 @@ renumber_mergeinfo_revs(svn_string_t **f
> > void *val;
> >
> > apr_hash_this(hi, &key, NULL, &val);
> > - merge_source = (const char *) key;
> > - rangelist = (apr_array_header_t *) val;
> > + merge_source = key;
> > + rangelist = val;
>
> Wouldn't it be better to just use our hash_index_key/val functions here?

Absolutely, but I was just doing a sweep of type-cast-to-array-* removal
and didn't want to stop and make other changes at that time. I'll do it
some time if no-one gets there before me.

- Julian
Received on 2010-03-12 00:54:50 CET

This is an archived mail posted to the Subversion Dev mailing list.