[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r921588 - in /subversion/trunk/subversion: include/svn_wc.h libsvn_wc/adm_files.h libsvn_wc/adm_ops.c

From: Julian Foad <julian.foad_at_wandisco.com>
Date: Thu, 11 Mar 2010 18:15:17 +0000

On Wed, 2010-03-10, neels_at_apache.org wrote:
> Author: neels
> Date: Wed Mar 10 22:00:38 2010
> New Revision: 921588
>
> URL: http://svn.apache.org/viewvc?rev=921588&view=rev
> Log:
> Strike the first blow at making svn_wc_[_]get_pristine_contents[2]() use wc-ng.
>
> The previous implementation of svn_wc_get_pristine_contents2() assumed a
> text-base file to always be present and never reflected a NULL return value to
> the callers, other than advertised. This patch fixes that return value.
>
> See also r921556, which prepared for this patch.
>
> (Still TODO for 1.7: svn_wc_get_pristine_contents2() and
> svn_wc__get_pristine_contents() should use the pristine store.)
>
> * subversion/include/svn_wc.h
> (svn_wc_get_pristine_contents2): Comment.
> Properly define this function so that we know what to implement when the
> pristine store rolls out.

Hoorrah! Thanks, Neels. /me gives big smiley.

[...]

(Not reviewed in detail.)

- Julian
Received on 2010-03-11 19:17:04 CET

This is an archived mail posted to the Subversion Dev mailing list.