[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r921445 - in /subversion/trunk/subversion: include/private/svn_wc_private.h include/svn_wc.h libsvn_client/commit.c libsvn_wc/entries.c

From: Philip Martin <philip.martin_at_wandisco.com>
Date: Thu, 11 Mar 2010 11:46:13 +0000

Greg Stein <gstein_at_gmail.com> writes:

> Sorry I wasn't clear. The function is only useful for situations like:
> $ svn rm path/some-subdir
> $ rm -r path/some-subdir

It needs an f: 'rm -rf'

> ... and then calling the function on path/some-subdir. It will record
> (in path/.svn/) that some-subdir is "not-present" in the working copy.
> The function is used as part of the commit code. Post-commit, we are
> allowed to mark that subdir as "not-present" in the new revision of
> path/... since we know it was deleted as part of the commit. We don't
> mind that the subdir is missing because that recording is in the stub
> located in path/.svn/
> That said, the function is bogus because this kind of recording should
> happen during commit processing naturally. And it should bump the
> revision on that directory, rather than just alter the presence value

Which revision/directory? The deleted directory doesn't have a
revision any more and the parent might not be changing.

> stashed away in the stub. We should be able to eliminate the function
> today, and fold it into commit processing (and then it *may* further
> simplify during the single-db move).

Once we have a singe-db then this sort of deleted directory stops
being special, it's just a normal deleted directory. We will have to
keep the function because it's part of the public API.

Received on 2010-03-11 14:34:34 CET

This is an archived mail posted to the Subversion Dev mailing list.