Re: svn commit: r921445 - in /subversion/trunk/subversion: include/private/svn_wc_private.h include/svn_wc.h libsvn_client/commit.c libsvn_wc/entries.c

On Wed, Mar 10, 2010 at 12:52, Philip Martin <philip.martin_at_wandisco.com> wrote:
> Philip Martin <philip.martin_at_wandisco.com> writes:
>
>> "Bert Huijben" <bert_at_qqmail.nl> writes:
>>>
>>> Shouldn't this be svn_node_directory and TRUE for parent_stub
>>> instead of unknown and FALSE?
>>>
>>> Only directories can be in obstructed_delete mode, and in this case
>>> I don't think you can't update the node in the directory itself.
>>
>> Dunno. I just moved the existing call.  I'll investigate.
>
> Seems to work either way, I guess modify2 has logic to deal with
> it. I've committed the change.

Yes, it does. With the svn_node_unknown in there, the code will look
at the disk to try and figure out what is going on. In this case, it
finds nothing on disk, so it says "read metadata from the parent, and
you'll find NAME in there". Reading the metadata can then tell you
whether NAME was supposed to be a file, a directory, or not even under
version control.

But it is MUCH better to pass what you know, rather than
svn_node_unknown. We won't stat() the disk in that case.

(see entries.c::get_entry_access_info())

Cheers,
-g
Received on 2010-03-11 06:19:54 CET