[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r921445 - in /subversion/trunk/subversion: include/private/svn_wc_private.h include/svn_wc.h libsvn_client/commit.c libsvn_wc/entries.c

From: Philip Martin <philip.martin_at_wandisco.com>
Date: Wed, 10 Mar 2010 17:26:27 +0000

"Bert Huijben" <bert_at_qqmail.nl> writes:

>> svn_wc_entry_t tmp_entry;
>>
>> tmp_entry.deleted = TRUE;
>> tmp_entry.schedule = svn_wc_schedule_normal;
>>
>> - return svn_error_return(
>> - svn_wc__entry_modify2(db, local_abspath, svn_node_unknown,
>> FALSE,
>> - &tmp_entry,
>> - (SVN_WC__ENTRY_MODIFY_DELETED
>> - | SVN_WC__ENTRY_MODIFY_SCHEDULE
>> - | SVN_WC__ENTRY_MODIFY_FORCE),
>> - pool));
>> + SVN_ERR(svn_wc__entry_modify2(wc_ctx->db, local_abspath,
>> + svn_node_unknown, FALSE, &tmp_entry,
>> + (SVN_WC__ENTRY_MODIFY_DELETED
>> + | SVN_WC__ENTRY_MODIFY_SCHEDULE
>> + | SVN_WC__ENTRY_MODIFY_FORCE),
>> + scratch_pool));
>
> Shouldn't this be svn_node_directory and TRUE for parent_stub
> instead of unknown and FALSE?
>
> Only directories can be in obstructed_delete mode, and in this case
> I don't think you can't update the node in the directory itself.

Dunno. I just moved the existing call. I'll investigate.

-- 
Philip
Received on 2010-03-10 18:27:05 CET

This is an archived mail posted to the Subversion Dev mailing list.