[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r921181 - in /subversion/trunk/subversion/bindings/javahl/native: CopySources.h JNIThreadData.h RevisionRange.h RevpropTable.h

From: Blair Zajac <blair_at_orcaware.com>
Date: Tue, 09 Mar 2010 14:46:17 -0800

On 03/09/2010 02:41 PM, hwright_at_apache.org wrote:
> Author: hwright
> Date: Tue Mar 9 22:41:16 2010
> New Revision: 921181
> URL: http://svn.apache.org/viewvc?rev=921181&view=rev
> Log:
> JavaHL: Fix a few header files to avoid a redundant declaration of SVN::Pool.
> Instead of declaring the class (when it might also be declared previously by
> some other header file), just include the header if needed. The header already
> has the required #ifdef protection, and it doesn't cost much to parse it
> again anyway.

Standard practice is to only include header files one needs for the
definition. Plus, it's not just that, but the cost of recompiling
everything that then #include's that header file if you touch Pooo.h

I suggest just reverse merging this change, as while it's not the cost
that matters (which is low as you state), but just being correct about it.

Received on 2010-03-09 23:46:48 CET

This is an archived mail posted to the Subversion Dev mailing list.