[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

RE: svn commit: r920526 - /subversion/trunk/subversion/libsvn_wc/update_editor.c

From: Bert Huijben <bert_at_qqmail.nl>
Date: Tue, 9 Mar 2010 12:01:05 +0100

> -----Original Message-----
> From: Julian Foad [mailto:julianfoad_at_btopenworld.com]
> Sent: dinsdag 9 maart 2010 11:15
> To: rhuijben_at_apache.org; dev_at_subversion.apache.org;
> commits_at_subversion.apache.org
> Subject: Re: svn commit: r920526 -
> /subversion/trunk/subversion/libsvn_wc/update_editor.c
>
> On Mon, 2010-03-08 at 21:34 +0000, rhuijben_at_apache.org wrote:
> > Author: rhuijben
> > Date: Mon Mar 8 21:34:38 2010
> > New Revision: 920526
> >
> > URL: http://svn.apache.org/viewvc?rev=920526&view=rev
> > Log:
> > * subversion/libsvn_wc/update_editor.c
> > (install_added_props): Remove call to
> svn_wc__db_base_set_dav_cache()
> > as the only caller, svn_wc_add_repos_file4() should never change
> > BASE_NODE information. (The information that was stored before this
> > patch is from the copy from origin, which is unrelated to the
> > BASE_NODE)
>
> Please could you update the function's doc string. It says "BASE_PROPS
> can contain entryprops and wcprops as well", implying that it does
> something with both kinds, and now it doesn't.

BASE_PROPS refers to the 'unmodified properties', to be stored in WORKING_NODE (See: @BASE), not to the properties of the BASE_NODE/checked out state (@ORIGINAL).
This comment was written before the definition changed with WC-NG.

        Bert
Received on 2010-03-09 12:01:38 CET

This is an archived mail posted to the Subversion Dev mailing list.