Re: svn commit: r920118 - in /subversion/trunk/subversion: libsvn_client/cleanup.c tests/cmdline/upgrade_tests.py tests/cmdline/upgrade_tests_data/upgrade_with_externals.tar.bz2

dannas_at_apache.org writes:

> Author: dannas
> Date: Sun Mar 7 21:21:58 2010
> New Revision: 920118
>
> + for (hi = apr_hash_first(scratch_pool, externals); hi;
> + hi = apr_hash_next(hi))
> + {
> + const char *key;
> + int i;
> + apr_ssize_t klen;
> + svn_string_t *external_desc;
> + apr_array_header_t *externals_p;
> +
> + svn_pool_clear(iterpool);
> + externals_p = apr_array_make(iterpool, 1,
> + sizeof(svn_wc_external_item2_t*));
> +
> + apr_hash_this(hi, (void*)&key, &klen, NULL);

Avoid the cast, use svn_apr_hash_index_key, etc.

> +
> + external_desc = apr_hash_get(externals, key, klen);
> +
> + SVN_ERR(svn_wc_parse_externals_description3(&externals_p,
> + svn_dirent_dirname(path,
> + iterpool),

Odd indentation.

> + external_desc->data, TRUE,
> + iterpool));

-- 
Philip