[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

[PATCH] #3483 - Extend svn_client_upgrade() to include externals

From: Daniel Nslund <daniel_at_longitudo.com>
Date: Sun, 7 Mar 2010 15:37:14 +0100

Hi Bert!

You said on IRC that if I adjusted this patch to apply after your
changes and sent it to dev@ you would give a +1. Will you?

I only resolved a variable declaration and added the new parameters to
svn_wc_upgrade(). You added a callback for retrieving the wc root when
upgrading from 1.0. As a external is just as any other wc, I mean that I
don't have to make any special considerations regarding the wc root
fetching.

make check passed.

[[[
Fix issue #3483 - extend svn_client_upgrade() to include externals. I've
done the externals upgrading after wc upgrade is finished. In that way
no errors in the externals will affect the wc.

* subversion/libsvn_client/cleanup.c
  (svn_client_upgrade): Get all svn:externals. We need the target_dir so
    we have to parse the description. For each target_dir we call
    svn_wc_upgrade() which will recursively upgrade the external.

* subversion/tests/cmdline/upgrade_tests.py
  (upgrade_with_externals): New. Checks the format of a 1.6 wc upgraded
    to wc-ng.
  (test_list): Add upgrade with_externals.

* subversion/tests/cmdline/upgrade_tests_data/upgrade_with_extenals.tar.bz2
  (...): New. An 1.6 wc with the same structure as those used in
    externals_tests.py.

Patch by: Daniel Nslund <daniel{_AT_}longitudo.com>
]]]

Received on 2010-03-07 15:37:52 CET

This is an archived mail posted to the Subversion Dev mailing list.