[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r919106 - in /subversion/trunk/subversion/libsvn_wc: adm_files.c adm_files.h

From: Greg Stein <gstein_at_gmail.com>
Date: Fri, 5 Mar 2010 12:28:17 -0500

On Thu, Mar 4, 2010 at 13:15, <julianfoad_at_apache.org> wrote:
> Author: julianfoad
> Date: Thu Mar  4 18:15:39 2010
> New Revision: 919106
>
> URL: http://svn.apache.org/viewvc?rev=919106&view=rev
> Log:
> Declare that two more WC functions always use absolute paths.
>
> * subversion/libsvn_wc/adm_files.h,
>  subversion/libsvn_wc/adm_files.c
>  (open_adm_file, svn_wc__open_writable_base): Rename path parameters to
>    indicate they are always absolute paths. No code changes are necessary.
>    (Each has only one caller and the caller already supplies absolute paths
>    as input.)

With only one caller, it may not be important, but we've also tended
to add assertions that the parameter is an absolute path. It is very
advisable for long-term APIs. I would expect both of these functions
to disappear, so it isn't that big of a deal, but I wanted to mention
the precedent.

>...

Cheers,
-g
Received on 2010-03-05 18:28:49 CET

This is an archived mail posted to the Subversion Dev mailing list.