[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

[RFC] svn_stream_t - should close on pool cleanup

From: Julian Foad <julianfoad_at_btopenworld.com>
Date: Fri, 05 Mar 2010 14:14:50 +0000

I was surprised to see that svn_stream_t does not register itself with
the pool cleanup handler, so a stream does not automatically get closed
if I destroy its pool.

I am not seeing any practical problem caused by this, and I don't know
of anything significant that any of our streams need to do on closure
(but haven't checked). It just seems wrong.

Thoughts?

(Some auto-close behaviours that we do have:

  Stream returned by svn_stream_from_apr_file():

    stream-close => file-close
    pool-destroy => file-close

)

- Julian
Received on 2010-03-05 15:15:29 CET

This is an archived mail posted to the Subversion Dev mailing list.