[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: WIN32_RETRY_LOOP and opening read-only files for writing.

From: C. Michael Pilato <cmpilato_at_collab.net>
Date: Tue, 02 Mar 2010 14:22:24 -0500

Lieven Govaerts wrote:
> WIN32_RETRY_LOOP tries in this case to open the file for writing, and
> gets an ERROR_ACCESS_DENIED error. Now I know this error can mean lots
> of things, so I don't propose to drop it altogether. But can't we add
> a check that, if svn gets this error during file opening, it checks
> first if the file is read-only before retrying 100 times?
> I see we already do something similar in svn_io_remove_file.
> Remarks?

Makes sense to me. We're assuming, of course, that any time we find such a
file read-only that it isn't merely set that way temporarily by some other
process, but I think that's a fair assumption to make.

C. Michael Pilato <cmpilato_at_collab.net>
CollabNet   <>   www.collab.net   <>   Distributed Development On Demand

Received on 2010-03-02 20:23:03 CET

This is an archived mail posted to the Subversion Dev mailing list.