Re: [PATCH] WC-NG properties API - complete doc strings

On Mon, 2010-03-01, Greg Stein wrote:
> On Mon, Mar 1, 2010 at 07:23, Julian Foad <julian.foad_at_wandisco.com> wrote:
> > For review, please. The patch below aims to provide complete doc
> > strings for (the existing implementation of) the WC-NG properties API.
>
> Looks great, thanks.

Great.

Bert said (on IRC):
> Absent, Excluded and Not-Present base nodes don't have properties
> stored in BASE_NODE.

To address that, I changed the wording from

  "Set *PROPS to the properties of the node LOCAL_ABSPATH in the
   WORKING tree if the node is found there, else in the BASE tree.
   ...
   If the node is not found in the BASE tree, ..."

and similar, to

  "Set *PROPS to the properties of the node LOCAL_ABSPATH in the
   WORKING tree (looking through to the BASE tree as required).
   ...
   If the node is not present, ..."

I think that conveys the required meaning better.

Committed in r917959.

- Julian
Received on 2010-03-02 12:12:39 CET