[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

RE: svn commit: r917512 - in /subversion/trunk/subversion/mod_dav_svn: mirror.c mod_dav_svn.c

From: Kamesh Jayachandran <kamesh_at_collab.net>
Date: Mon, 1 Mar 2010 23:34:34 +0530

Modified as suggested.

Thanks
With regards
Kamesh Jayachandran

-----Original Message-----
From: Blair Zajac [mailto:blair_at_orcaware.com]
Sent: Mon 3/1/2010 10:47 PM
To: kameshj_at_apache.org
Cc: dev_at_subversion.apache.org
Subject: Re: svn commit: r917512 - in /subversion/trunk/subversion/mod_dav_svn: mirror.c mod_dav_svn.c
 
kameshj_at_apache.org wrote:
> Author: kameshj
> Date: Mon Mar 1 13:15:58 2010
> New Revision: 917512
>
> URL: http://svn.apache.org/viewvc?rev=917512&view=rev
> Log:
> Follow-up to r916286.
>
> * subversion/mod_dav_svn/mod_dav_svn.c
> (create_dir_config):
> * subversion/mod_dav_svn/mirror.c
> (dav_svn__location_in_filter, dav_svn__location_body_filter):
> Use 'svn_uri_canonicalize' on url paths.

A minor comment on the log messages. The lines beginning with () are indented
two spaces and each source file has one vertical whitespace separating it from
other files. This makes it much easier to visually parse the log message to
quickly see what's being changed:

* subversion/mod_dav_svn/mod_dav_svn.c
   (create_dir_config):
   Use 'svn_uri_canonicalize' on url paths.

* subversion/mod_dav_svn/mirror.c
   (dav_svn__location_in_filter, dav_svn__location_body_filter):
   Use 'svn_uri_canonicalize' on url paths.

Regards,
Blair
Received on 2010-03-01 19:05:37 CET

This is an archived mail posted to the Subversion Dev mailing list.