[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] 'svn patch' should remove empty dir

From: Neels J Hofmeyr <neels_at_elego.de>
Date: Mon, 01 Mar 2010 10:49:30 +0100

Julian Foad wrote:
> On Sat, 2010-02-27, Daniel Näslund wrote:
>> Reviews welcome!
>>
>> [[[
>> Make 'svn patch' able to remove dirs beeing empty after patching, taken
>> into account both versioned and unversioned files and dirs.
>>
>> * subversion/tests/cmdline/patch_tests.py
>> (patch_remove_empty_dir): New.
>> (test_list): Add new test.
>>
>> * subversion/libsvn_client/patch.c
>> (status_baton): New.
>> (find_existing_children, is_dir_empty,
>> add_target_to_hash_keyed_by_parent_dir, is_dir_empty,
>> sort_compare_nr_of_path_elements,
>> maybe_condense_deleted_targets): New functions
>> (apply_patches): Call maybe_condense_deleted_targets(). Check if a
>> target has a patch associated with it before calling
>> svn_diff__close_patch() since we're creating targets to delete dirs
>> and those have no associated patch.
>>
>> Patch by: Daniel Näslund <daniel{_AT_}longitudo.com>
>> Review by: julianf, stsp, neels
>
> Huh? - - - - - ^^
>
> Trying to twist my arm into reviewing it by posting a patch that says I
> have? :-)

heh :)
AFAIR you have partaken in the review of a previous version of this patch.
Looking, I see that you have actually just commented a little...

http://mail-archives.apache.org/mod_mbox/subversion-dev/201002.mbox/%3C1266921402.4271.246.camel@edith%3E

and

http://mail-archives.apache.org/mod_mbox/subversion-dev/201002.mbox/%3C1266841064.4271.146.camel@edith%3E

How important is it to us to have 'Review by: <full-committer>' crediting
anyway?

~Neels

Received on 2010-03-01 10:50:12 CET

This is an archived mail posted to the Subversion Dev mailing list.