[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Finding a proper name for @base

From: Neels J Hofmeyr <neels_at_elego.de>
Date: Wed, 24 Feb 2010 17:46:15 +0100

Hi all,

I'm at the point where the svn client wants to get the revision it knows as
svn_opt_revision_base, aka the @base commandline keyword, from wc_ng.
svn_opt_revision_base means:

  The checked out revision of the node, but if this node's
  base is shadowed then the revision of the shadowing base.
  base-shadowed means:
   locally added with history = (locally replaced-by-copy/move
                                 or locally copied/moved-here)
  so svn_opt_revision_base wants the rev of the source of any copy/move.

Now, we already have the svn_wc__node_get_base_rev() function, but it
returns the *other* base, i.e. the wc-ng-base, the BASE-tree revision, or in
other words:

  *Always* the checked out revision of the node, regardless
  of any modifications, copies, moves or replaces.

There definitely needs to be another function like
svn_wc__node_get_base_rev(), which returns the svn_opt_revision_base
variant. All I need from you is a proper name for that.

So far I have these in the pool of choices:

  svn_wc__node_get_working_rev()
   (corresponds to svn_opt_revision_working, since the revision number
    of svn_opt_revision_working is the same as svn_opt_revision_base's
    revision number)

  svn_wc__node_get_working_base_rev()
   :/

  svn_wc__node_get_shadowing_base_rev()
   (base is shadowed, and we don't want the shadowed base, we
    want the shadow*ing* base)

  svn_wc__node_get_newer_base_rev()
   :/

It's time to clarify the naming, please help!
Any better suggestions?

~Neels

Received on 2010-02-24 17:46:53 CET

This is an archived mail posted to the Subversion Dev mailing list.