On Thu, 18 Feb 2010, Julian Foad wrote:
> Peter Samuelson wrote:
>> [Stefan Sperling]
>>> Have you seen ^/subversion/branches/1.6.x-wc-ng-check-override ?
>>> I think that's the workaround you need. Log of the branch below.
>>> It's already nominated for backport, so if you like it, please vote :)
>> I hadn't seen it. Yes, this solves the problem - but I'm not sure this
>> 'permission denied' should really require a workaround like
>> export SVN_I_LOVE_CORRUPTED_WORKING_COPIES_SO_DISABLE_CHECK_FOR_WC_NG=yes
>> Jon, what's your opinion on Stefan's approach?
> I'm not Jon but my opinion is that we need a bug fix, not a work-around,
> and that Peter's patch
> <http://svn.haxx.se/dev/archive-2010-02/0431.shtml> is the sort of fix
> we need. (I haven't reviewed it, just glanced over it.)
> Let's check I understood the problem correctly: User has 1.6 client and
> 1.6 WCs, no 1.7 stuff involved at all. User's system has a WC rooted at
> the file system root: '/.svn' exists and is not readable by this user.
> In some normal operations that used to work with svn 1.6.x, svn 1.6.9
> tries to look for a file '/.svn/wc.db' and throws an error because it's
> denied access to that directory.
Correct. And Peter's simpler example in the debian bug page:
is a little different, but the same issue.
One other clarification is that the WC in one of the parent directories is
completely unrelated to the WC in the subdirectory.
ie. the repository (and/or method and path) for / is completely different
than the repository for /home/me/test/ and so anything it is looking for
in /home would be wrong, even in the case of the new 1.7 feature where
there is only one .svn directory for each checkout, because in my example
both / and /home/me/test would both have a .svn directory in it.
I don't know the code base well enough (or even at all), but it seems to
me that Peter's patch looked good.
I am also uneasy about the "I_LOVE_CORRUPTED_WCS" flag as a fix to this
problem, as I don't particularly love them at all, and if there were
corruption, I would want to know about it, and not silently ignore it.
I refuse to join any club that would have me as a member.
-- Groucho Marx
Received on 2010-02-19 06:32:52 CET