RE: [PATCH] wc-ng: remove a use of svn_wc_entry_t from libsvn_client

> -----Original Message-----
> From: Stefan Sperling [mailto:stsp_at_elego.de]
> Sent: woensdag 17 februari 2010 19:30
> To: Matthew Bentham
> Cc: dev_at_subversion.apache.org
> Subject: Re: [PATCH] wc-ng: remove a use of svn_wc_entry_t from
> libsvn_client
>
> On Wed, Feb 17, 2010 at 06:18:56PM +0000, Matthew Bentham wrote:
> > Index: subversion/libsvn_wc/node.c
> >
> ==========================================================
> =========
> > --- subversion/libsvn_wc/node.c (revision 909397)
> > +++ subversion/libsvn_wc/node.c (working copy)
> > @@ -310,6 +310,32 @@
> > db, local_abspath,
> > scratch_pool,
scratch_pool));
> > }
> > + else if (status == svn_wc__db_status_deleted)
> > + {
> > + const char *current_abspath = local_abspath;
> > + apr_pool_t *iterpool = svn_pool_create(scratch_pool);
> > + while (status == svn_wc__db_status_deleted)
> > + {
> > + svn_pool_clear(iterpool);
> > + svn_dirent_split(current_abspath,
> > + &current_abspath,
> > + NULL, scratch_pool);
> > +
> > + SVN_ERR(svn_wc__db_read_info(&status, NULL, NULL,
> &repos_relpath,
> > + &repos_root_url, NULL, NULL,
NULL,
> > + NULL, NULL, NULL, NULL,
NULL, NULL,
> > + NULL, NULL, NULL, NULL,
NULL, NULL,
> > + NULL, NULL, NULL, NULL,
> > + db, current_abspath,
> > + scratch_pool, iterpool));
> > + }

This sounds like svn_wc__db_scan_deletion(), svn_wc__db_scan_base_repos()
and friends?

These should handle the scanning upwards for you.

Note that while you usually can find repos_root_url on every directory, the
WC-NG schema allows it to be defined only on the WC-Root.
(Our current entry based writing code will write it to every directory; but
that is not necessary for our schema)

        Bert
Received on 2010-02-18 12:13:54 CET