[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] wc-ng: remove a use of svn_wc_entry_t from libsvn_client

From: Matthew Bentham <mjb67_at_artvps.com>
Date: Wed, 17 Feb 2010 18:18:56 +0000

On 17/02/2010 17:53, stsp_at_stsp.name wrote:
> To save a (probably negligible) bit of memory,
> you could create an iterpool here...
>
> I think you should use svn_dirent_is_child() rather than svn_uri_is_child()
> here. The URI functions are for URLs, not local absolute paths.
>
> [1] Which would mean that these NULL checks are probably not necessary:

Implemented these in revised patch attached.

Matthew

[[[
wc-ng: work towards eliminating svn_wc_entry_t

* subversion/libsvn_client/commit_util.c
      (add_lock_token): Replace a use of svn_wc__maybe_get_entry with
       use of svn_wc__node_get_*
* subversion/libsvn_wc/node.c
      (svn_wc__internal_node_get_url): Find the URL of deleted nodes

Patch by: Matthew Bentham <mjb67{_AT_}artvps.com>
]]]

Received on 2010-02-17 19:19:34 CET

This is an archived mail posted to the Subversion Dev mailing list.