[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] wc-ng: remove a use of svn_wc_entry_t from libsvn_client

From: Matthew Bentham <mjb67_at_artvps.com>
Date: Wed, 17 Feb 2010 17:22:13 +0000

On 15/02/2010 15:02, Philip Martin wrote:
>> Indentation is a bit off. I'll fix and commit when the regression tests
>> finish.
>
> lock_tests.py 13 is failing:
>
> I think the problem is that svn_wc__node_get_url doesn't work for
> deleted nodes, it certainly has no code to scan the working tree for
> deletions.

Revised patch attached fixes the unit test (and hopefully the
indentation, if I've understood the style correctly), but I have no real
instinct as to whether I should be modifying a libsvn_wc routine in this
way. Should I be able to implement the client using functionality
libsvn_wc already exports?

[[[
wc-ng: work towards eliminating svn_wc_entry_t

* subversion/libsvn_client/commit_util.c
     (add_lock_token): Replace a use of svn_wc__maybe_get_entry with
      use of svn_wc__node_get_*
* subversion/libsvn_wc/node.c
     (svn_wc__internal_node_get_url): Find the URL of deleted nodes

Patch by: Matthew Bentham <mjb67{_AT_}artvps.com>
]]]

Received on 2010-02-17 18:22:50 CET

This is an archived mail posted to the Subversion Dev mailing list.