[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

[PATCH] Fix the commit failure over the write-through-proxy if apache is configured as '<Location /svn/>'

From: Kamesh Jayachandran <kamesh_at_collab.net>
Date: Mon, 15 Feb 2010 19:04:45 +0530

Hi All,

With the below apache configuration(See the trailing slash at the end of
'/svn/').

<Location /svn/>
   DAV svn
   SVNParentPath /repositories
   SVNMasterURI http://master/svn/
   SVNAdvertiseV2Protocol Off
</Location>

We get the following error on the client while.

../subversion/svn/commit-cmd.c:142: (apr_err=175002)
../subversion/libsvn_client/commit.c:853: (apr_err=175002)
svn: Commit failed (details follow):
../subversion/libsvn_ra_neon/commit.c:1463: (apr_err=175002)
../subversion/libsvn_ra_neon/commit.c:334: (apr_err=175002)
../subversion/libsvn_ra_neon/util.c:613: (apr_err=175002)
svn: MKACTIVITY of
'/svn/demujin/!svn/act/4b6d547c-018d-4e02-9d3f-2b283076cc06': Could not
read status line: connection was closed by server (http://localhost)

On the server it is a assertion error on the following code block from
subversion/mod_dav_svn/mirror.c:proxy_request_fixup

    assert((uri_segment[0] == '\0')
            || (uri_segment[0] == '/'));

For the above configuration we get the uri_segment with the value
'reponame/some/path/inside/the/repo'.

Attached patch fixes it.

This change came via fix for issue 3275. I believe this assertion is
just to clean the uri for double slash and not anything functional to
that issue, I may be wrong.

Thoughts?

Thanks
With regards
Kamesh Jayachandran

Received on 2010-02-15 14:36:39 CET

This is an archived mail posted to the Subversion Dev mailing list.