[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] v2 Test context within fuzzy hunk for 'svn patch'

From: Julian Foad <julian.foad_at_wandisco.com>
Date: Sat, 06 Feb 2010 00:29:00 +0000

Daniel Näslund wrote:
> Stefan Sperling wrote:
[...]
> > * subversion/tests/cmdline/patch_tests.py
> > (patch_with_fuzz): For determining fuzz we have an algorithm that
> > should only check for trailing and leading context. Make this test
> > verify that this property of the algorithm holds by adding context
> > in the middle of one of the hunks. Also fix an indentation error.
> >
> > What do you think?
>
> Looks good.

It's *beautiful*.

:-)

> This sounds silly but I often feel a bit of rush when I'm
> finished with a patch. It's like if I was thinking to myself: 'If I don't
> get it in immediately, the bug may disappear by itself'. I'm trying
> to slow down and give more thought to things. The most valueable lesson
> so far from contributing to subversion is the importance of beeing
> concious of all the choises I make when programming. In the end, writing
> a log message should be pretty easy if I really understand what I've
> been doing. :-)

I recognize those thoughts.

- Julian
Received on 2010-02-06 01:29:39 CET

This is an archived mail posted to the Subversion Dev mailing list.