-----BEGIN PGP SIGNED MESSAGE-----
Julian Foad wrote:
> I committed the patch (with that fix) in 901797.
> Thanks for the patch.
> Now I am running the test suite on your patch to use
> 3C4B2B12EA.5000208_at_collab.net%3E>, that depends on this one.
Assertion failure occurred due to a non-canonical base URL passed to
`svn_path_url_add_component2()'. Despite having canonicalized them
wherever they are generated, the reason for this was that in
`end_element()' of props.c, canonicalization was done where the url was
return assign_rsrc_url(pc->rsrc, svn_uri_canonicalize(cdata, pc->pool),
But there's one more place(which I missed to notice) where the value of
`cdata'(non-canonical url) is used to assigned the URL, for those
files/dirs who've parent info(cp/mv operations). So the non-canonical
URL was this one and hence the failure.
Attached herewith is the patch which canonicalizes `cdata' where its
initialized as proposed in . Though there's one more place:
/* Parse the <status> tag's CDATA for a status code. */
if (ne_parse_statusline(cdata, &status))
return svn_error_create(SVN_ERR_XML_MALFORMED, NULL, NULL);
that does not need the canonicalized value, thought its better to do the
canonicalization in just one place.
Follow-up r901797. Canonicalization of BASE URL doesn't reflect for
resources having parent info, till now.
(end_element): Canonicalize the BASE URL initially itself in order to
reflect the same for resources having parent info and otherwise.
Patch by: Kannan R <kannanr_at_collab.net>
With this, the upgrade to ..add_component2() could be performed(hope),
whose link is also found in .
P.S: `make davautocheck` passed :)
Thanks & Regards,
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/
-----END PGP SIGNATURE-----
Received on 2010-02-04 18:02:36 CET