--editor-cmd option of the 'pe' subcommand did not work if the path of the external text editor contains space

Hi there,

I found the --editor-cmd option of the 'pe' subcommand did not work if the
path of your external text editor contains space. Here is my environment:

Operating System: Microsoft Windows XP Professional Version 2002 Service
Pack 3

Release of Subversion: version 1.6.4 (r38063)

Compiler: No compiler. I used the binary installation file.

Configuration: No special configuration. I just enable the password option.

Private Modification: None

Here is the command I used under command-line console:

C:\temp\svn_trunk>svn pe --editor-cmd "C:\Program Files\Vim\vim72\gvim.exe"
myproperty file1.txt

'C:\Program' is not recognized as an internal or external command,

operable program or batch file.

svn: system('C:\Program Files\Vim\vim72\gvim.exe svn-prop.tmp') returned 1

The space was still treated as a special separator. Then I tried to escape
the space with the character ^.

C:\temp\svn_trunk>svn pe --editor-cmd "C:\Program^ Files\Vim\vim72\gvim.exe"
myproperty file1.txt

It did invoke the external text editor, in this case is vim, successfully
but then I found another problem that it treated the content behind the
space, in this case is Files\Vim\vim72\gvim.exe, as the temporary file to
hold the contents of the property, so it still did not work. :)

I also tested this feature on Windows 2000 Ad Server and the result was the
same as the one I got on Windows XP. To temporarily solve the problem, we
can define the external text editor by SVN_EDITOR environment. That works
perfect even the path of the external text editor has space.

I would like to know whether this is a bug. Thanks.

Best Regards,

Claude Xu
Received on 2010-02-03 06:40:06 CET