RE: svn commit: r904435 - in /subversion/site/publish: ./ dev/ docs/ docs/release-notes/ security/ style/

> -----Original Message-----
> From: Bert Huijben [mailto:bert_at_qqmail.nl]
> Sent: vrijdag 29 januari 2010 11:54
> To: dongsheng_at_apache.org
> Cc: dev_at_subversion.apache.org; commits_at_subversion.apache.org
> Subject: RE: svn commit: r904435 - in /subversion/site/publish: ./ dev/ docs/
> docs/release-notes/ security/ style/
>
>
>
> > -----Original Message-----
> > From: dongsheng_at_apache.org [mailto:dongsheng_at_apache.org]
> > Sent: vrijdag 29 januari 2010 10:38
> > To: commits_at_subversion.apache.org
> > Subject: svn commit: r904435 - in /subversion/site/publish: ./ dev/ docs/
> > docs/release-notes/ security/ style/
> >
> > Author: dongsheng
> > Date: Fri Jan 29 09:37:39 2010
> > New Revision: 904435
> >
> > URL: http://svn.apache.org/viewvc?rev=904435&view=rev
> > Log:
> > Remove 'svn:executable' from html files, add 'svn:mime-type' to css file
>
> Why did you remove the 'svn:executable' from the html files?
>
> This breaks the server side includes... and this commit broke the entire UI on
> our website (http://subversion.apache.org/)
> It removes the header, menu, etc.

I reverted r904435 in r904457.

See http://httpd.apache.org/docs/2.2/mod/mod_include.html#xbithack for the details on why the svn:executable was/is necessary.

I can see why you determined that this commit was a trivial patch outside your partial commit area (which doesn't require approval), but I would recommend that you consult the list first before repairing things if you are not 100% sure :)

+1 to apply the other changes (content types) again.

Thanks,

        Bert
Received on 2010-01-29 12:05:53 CET