[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r903507 - /subversion/trunk/tools/dev/unix-build/Makefile.svn

From: Hyrum K. Wright <hyrum_wright_at_mail.utexas.edu>
Date: Wed, 27 Jan 2010 07:01:35 -0800

On Jan 27, 2010, at 12:22 AM, Stefan Sperling wrote:

> On Tue, Jan 26, 2010 at 05:11:46PM -0800, Hyrum K. Wright wrote:
>>
>> On Jan 26, 2010, at 4:04 PM, neels_at_apache.org wrote:
>>
>>> Author: neels
>>> Date: Wed Jan 27 00:04:16 2010
>>> New Revision: 903507
>>>
>>> URL: http://svn.apache.org/viewvc?rev=903507&view=rev
>>> Log:
>>> * tools/dev/unix-build/Makefile.svn: Add missing line ending chars.
>>
>> I'm curious: why do we need to make this change? It would appear to me that the prior version would work just fine.
>
>>> $(SVN_OBJDIR)/.bindings-installed: $(SVN_OBJDIR)/.bindings-compiled
>>> if [ $(ENABLE_PYTHON_BINDINGS) = yes ]; then \
>>> cd $(svn_builddir) \
>>> - && make install-swig-py
>>> + && make install-swig-py; \
>>> fi
>
> I guess without ; \, make will try to execute 'fi'
> on its own. All shell commands need to be on a single
> logical line (from make's point of view).

Ah, yes. I didn't realize it was in a Makefile.

-Hyrum
Received on 2010-01-27 16:02:17 CET

This is an archived mail posted to the Subversion Dev mailing list.