[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Fix failing ci caused in r40202

From: Kannan <kannanr_at_collab.net>
Date: Thu, 21 Jan 2010 17:26:39 +0530

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Julian Foad wrote:
[..]
> In the second place it is used, we know it holds a URL:
>
>> case ELEM_href:
>> /* Special handling for <href> that belongs to the <response> tag. */
>> if (rsrc->href_parent == ELEM_response)
>> return assign_rsrc_url(pc->rsrc, cdata, pc->pool);
>
> That's where we can canonicalize it. And are there any other places
> where the "cdata" variable is known to hold a URL? I'm looking... No,
> there are no others. In all the rest of the places, it is providing a
> generic "property value".
>
> With that fix, I believe the patch will be correct.

Thank you for the comments, Julian. I thought it's better to
canonicalize in the first place, but should be otherwise! Attaching the
updated patch as per your feedback, herewith.

[[[
Log:
Ensure the URLs in libsvn_ra_neon are always canonical.

[ in subversion/libsvn_ra_neon ]

* ra_neon.h
  (svn_ra_neon__request_get_location): Update doc string to reflect that
   it returns a canonicalized URL.

* util.c
  (svn_ra_neon__request_get_location): Canonicalize the 'BASE URL' as
   per the rule.

* props.c
  (end_element): Same.

* options.c
  (end_element): Same.

Found by: stsp
Suggested by: stsp, julianfoad
Patch by: Kannan R <kannanr_at_collab.net>
]]]

- --
Thanks & Regards,
Kannan
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iQEVAwUBS1hA93lTqcY7ytmIAQIKLgf+P5n39GaVhl53zJ4oaEQOVMMX0ovSerqQ
Taakt6wLMuQREhnCoLzivk8phn3zyFXRV4wiqFly94X2wKFcKCX/K3I4nheecM5W
j/+DPQo4MLnFZDh8eJXuI4RpCR6+iP5Vz0wciE2nsVYt3+EJFGtqm+ZQTkgmj2iX
QnuVe55/GfNjIcsrqmJnjhwJ8W/YbKeBUq2iueeUPcC0m6T60WfK6Fy/3aEVVCYn
W/7TshgnFClyLdfAXDF8byrf5+fYDRjH49LBv7IMcd8A4krALCZ4+whYIIQNS2A7
byBGrTdViBtWr5vOO0POQEWwYMX8J9pLc5dNP/3LlzaM8CGReXb2AA==
=Fqzw
-----END PGP SIGNATURE-----

Received on 2010-01-21 13:05:22 CET

This is an archived mail posted to the Subversion Dev mailing list.