[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Fix #3544 - svn update does not restore excluded files

From: Kannan <kannanr_at_collab.net>
Date: Mon, 18 Jan 2010 10:16:10 +0530

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

C. Michael Pilato wrote:
[..]
> This patch doesn't apply cleanly anymore because I committed one of you
> other ones. The conflict is pretty easy to resolve, though.

Yes, as said in this thread before the change in this patch is the
required one.

> That said, I don't understand the changes to fold_entry(). The function's
> purpose is to modify an entry_t by copying a subset of fields from another
> entry_t. It seems an odd place to put code that tweaks that entry_t's
> "depth" field without respect to either the source entry_t's value or to the
> flagset that dictates which fields to modify.
>
>

/me nods. A file has the default and only depth of `infinity', so it's
depth can't be updated to the dir's(ie, source entry's), also
fold_entry() is the method where individual entries are obtained and
processed, so made the change there. (In the process of finding some
other place to make the change) please CMIIW. Thank you for the comments.

- --
Thanks & Regards,
Kannan
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iQEVAwUBS1PnknlTqcY7ytmIAQJiUgf8DIBnIAx2j8NBKEtB5hPxNA7z7ZUxFFFE
TytdjgxtkYPXYl4+RpYRNJsXEEaV0RFrzLRw/vu6y8OCg4YgNZCf1rT6kMa7sx7l
w3UpgkbIeBPAKDW4f9s4MWd69oiNpZLOIXdBa9pZv+x7mMlhSa7pqXrQi/4j4rVh
ndVBPeQsSdEKhgnR98y5H0ZeWXF+i/fkjKixBbXoI71uq9tyaFC7UE2IBPzLn6iY
/W9D30wNYWZSWXDyU5Gu+oMU4H5hGRkl5exfsWl+5leHfbnCwqAFSa/9CY3gb35q
GSYUXsf+yhVTUhY81dcahs5HGYcR8/J6soVebMNuaPL+FUjstEHHUw==
=vvFa
-----END PGP SIGNATURE-----
Received on 2010-01-18 05:54:25 CET

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.