[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [NEW TARBALLS] Re: 1.6.8 up for signing / testing

From: Paul Burba <ptburba_at_gmail.com>
Date: Thu, 14 Jan 2010 20:32:42 -0500

On Thu, Jan 14, 2010 at 7:52 PM, Bert Huijben <bert_at_qqmail.nl> wrote:
>
>
>> -----Original Message-----
>> From: Philip Martin [mailto:philip.martin_at_wandisco.com]
>> Sent: donderdag 14 januari 2010 20:29
>> To: Mark Phippard
>> Cc: Paul Burba; Hyrum K. Wright; Bert Huijben; Joe Swatosh; Subversion
>> Dev
>> Subject: Re: [NEW TARBALLS] Re: 1.6.8 up for signing / testing
>>
>
>> I don't understand. it.  The server generates baseline collection URLs
>> with a trailing slash (a DeltaV requirement?) in dav_svn__build_uri:
>>
>>     case DAV_SVN__BUILD_URI_BC:
>>       return apr_psprintf(pool, "%s%s/%s/bc/%ld/%s",
>>                           href1, root_path, special_uri, revision,
>> href2);
>>
>> and I see the trailing slashes on wire.  The trunk client has a call
>> to svn_uri_canonicalize that is not present on the branch, so the
>> branch aborts. If I add a svn_path_canonicalize call the problem is
>> fixed.  How do some machines avoid the problem?
>
> The check is inside an assert(), so it only aborts in maintainer/DEBUG mode.
>
>        Bert

Doh, Thanks Bert. I wasn't paying close enough attention. Indeed it
does assert with a debug build:

C:\SVN\src-branch-1.6.x\Release\subversion\tests\cmdline\svn-test-work\repositories>svn
cp -mc http://localhost/svn-test-work/repositories/repo/A
http://localhost/svn-test-work/repositories/repo/A2 --config-dir=.
--username=jrandom --password=rayjandom
Assertion failed: svn_path_is_canonical(url, pool), file
..\..\..\subversion\libsvn_subr\path.c, line 955

Paul
Received on 2010-01-15 02:33:22 CET

This is an archived mail posted to the Subversion Dev mailing list.