Re: [PATCH] v2 #3483 - Extend svn_client_upgrade() to include externals

Hi!

[[[
Fix issue #3483 - extend svn_client_upgrade() to include externals. I've
done the externals upgrading after wc upgrade is finished. In that way
no errors in the externals will affect the wc.

* subversion/libsvn_client/cleanup.c
  (svn_client_upgrade): Get all svn:externals. We need the target_dir so
    we have to parse the description. For each target_dir we call
    svn_wc_upgrade() which will recursively upgrade the external.

* subversion/tests/cmdline/upgrade_tests.py
  (upgrade_with_externals): New. Checks the format of a 1.6 wc upgraded
    to wc-ng.
  (test_list): Add upgrade with_externals.

* subversion/tests/cmdline/upgrade_tests_data/upgrade_with_extenals.tar.bz2
  (...): New. An 1.6 wc with the same structure as those used in
    externals_tests.py.

Patch by: Daniel Näslund <daniel{_AT_}longitudo.com>
]]]

A big thank you to Bert for putting up with all my questions on IRC.

My previous patch didn't handle relative externals all that well. And it
failed to upgrade file externals too. I've added a testcase to this
patch to prove that this one does things right.

BUT, the testcase does not check the statustree of the wc after the
upgrade. I didn't understand how to set up a statustree to check
against.

Daniel