Re: [PATCH] #3483 - Extend svn_client_upgrade() to include externals

On Mon, Dec 28, 2009 at 10:31:15PM +0100, Daniel Näslund wrote:
> Hi!
>
> [[[
> Fix issue #3483 - extend svn_client_upgrade() to include externals. I've
> done the externals upgrading after wc upgrade is finished. In that way
> no errors in the externals will affect the wc.
>
> * subversion/libsvn_client/cleanup.c
> (svn_client_upgrade): Get all svn:externals. We need the target_dir so
> we have to parse the description. For each target_dir we call
> svn_wc_upgrade() which will recursively upgrade the external.
>
> Patch by: Daniel Näslund <daniel{_AT_}longitudo.com>
> ]]]
>
> I have only tested this patch with the supplied shell script.

Forgot the shell script. It doesn't test much but it's better than
nothing.
 
> As for performance. Bert told me today on IRC that we will gain more
> speed once the property stuff is in the db. We walk the wc two
> times, one for the original wc upgrade and another when searching for
> externals definitions. Hopefully, caching will ease the burden.
>
> I have one formatting issue with the svn_dirent_dirname(). If anyone has
> a better suggestion I'm upen for discussion (That is, I will do whatever
> you tell me to do).
>
> Daniel