Re: svn commit: r893179 - in /subversion/trunk/subversion/libsvn_fs_base: dag.c revs-txns.c

Philip Martin wrote:
> node_origins_update() also has a loop that doesn't use an iteration
> pool:
>
> SVN_ERR(svn_fs_bdb__changes_fetch_raw(&changes, trail->fs, old_txn_id, trail,
> scratch_pool));
> for (i = 0; i < changes->nelts; i++)
> {
>
> I suppose fetch_raw is already allocating memory that is proportional
> to the number of changes, so perhaps that's sufficient justification
> not to use an iteration pool in this case.

Still worth doing. Done in r893509.

Thanks.
- Julian
Received on 2009-12-23 14:47:46 CET