Re: svn commit: r893267 - in /subversion/trunk/subversion/libsvn_fs_base: bdb/node-origins-table.c bdb/node-origins-table.h dag.c revs-txns.c

julianfoad_at_apache.org wrote:
> Author: julianfoad
> Date: Tue Dec 22 18:44:27 2009
> New Revision: 893267
>
> URL: http://svn.apache.org/viewvc?rev=893267&view=rev
> Log:
> For obliterate in BDB, implement updating the "node-origins" table.
>
> * subversion/libsvn_fs_base/bdb/node-origins-table.c,
> subversion/libsvn_fs_base/bdb/node-origins-table.h
> (svn_fs_bdb__change_node_origin): New function to overwrite an existing
> node-origins row.

Why not just re-use the existing __delete_node_origin() and
__set_node_origin() functions? Or a boolean 'allow_overwrite' flag to
__set_node_origin()?

Disclaimer: I haven't examined in detail the nuances of the calling
requirements of these various functions or your new one.

-- 
C. Michael Pilato <cmpilato_at_collab.net>
CollabNet   <>   www.collab.net   <>   Distributed Development On Demand