[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Fix failing ci caused in r40202

From: Kannan <kannanr_at_collab.net>
Date: Tue, 22 Dec 2009 17:20:25 +0530

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Julian Foad wrote:
[..]
> OK. The policy in Subversion is that the paths and URLs passed in and
> out of all APIs are canonical unless otherwise stated. Therefore we
> should make do_checkout() set its "locn" output parameter to a canonical
> URL.
>
>>> If the former, we should look for all other uses of ne_uri_parse() and
>>> canonicalize after them as well. If the latter, we should fix the
>>> do_checkout() function and look for all other uses of
>>> svn_ra_neon__request_get_location().
>
> Oops - when I wrote that, I was thinking
> svn_ra_neon__request_get_location() was an external (non-Subversion)
> function, but it is a Subversion function so it should return a
> canonical URL.
>
>> Does this imply to make `svn_ra_neon__request_get_location()' create a
>> non-canonical URL by default?
>
> No, it should create a canonical URL. The fix we need is inside
> svn_ra_neon__request_get_location(), or at least we need to look inside
> that function to see where the non-canonical URL is coming from, and
> maybe trace further back to find the cause of the problem.

Oops, typo. Meant to ask for canonical. I'll give a shot to try where
the non-canonicalized is possibly created in ..get_location().

>>> (What does the non-canonical URL or URI look like?)
>> http://localhost/repos/devrepo/!svn/wrk/b4ec0dff-9abf-42ee-8860-a6a9630218e4/
>>
>> (which is generated by do_checkout() and parse.path value would be:
>>
>> /repos/devrepo/!svn/wrk/b4ec0dff-9abf-42ee-8860-a6a9630218e4/ )
>
> Thanks.

Thank you.

- --
Thanks & Regards,
Kannan
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iQEVAwUBSzCygXlTqcY7ytmIAQIEtwf+I6hYI5boCQk5bL7Fw9sxatDn7V6YD3t8
LIqRWaxlWCmQ6vAdPJY2LqzRAaxxgQD8yLi09ngWv1itPxqiJak0Gd8OjRoof5LK
F9XO6XZ6kx221AGhmSLrFaSiVlbREOwbYve1U7OF3eY7QocK6X5uN1EINlsQJJSd
rTfGLvQte3XFj9p+9vIcYLKMuiKdw0IcaMarSakg+DodMOcGsTXSyaHKZr/V8A98
BpmnJ0H7NJrnmvTVllFCgR6O3SeMKaeklnjClnS3Zg+3Gw+cJKOP0+6WG+k5lLvt
bIO7jZNoC8QXEPUGpW1bII6vJWx2p17+OK4hYqLuYt7tYGWQeM7jFg==
=W9M9
-----END PGP SIGNATURE-----
Received on 2009-12-22 12:55:18 CET

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.