-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Julian Foad wrote:
[..]
> Hi Kannan.
>
> With your patch, the code in "commit.c" now looks like this (ignoring
> all the error handling):
>
> do_checkout():
> ...
> *locn = svn_ra_neon__request_get_location(request, pool);
>
> checkout_resource():
> do_checkout(cc, rsrc->vsn_url, allow_404, token, &code, &locn, pool);
> ne_uri_parse(locn, &parse);
> rsrc->wr_url = svn_uri_canonicalize(parse.path, rsrc->pool);
>
> Does the "ne_uri_parse" function create a non-canonical ".path", or does
> the do_checkout() function create a non-canonical URL?
`do_checkout()' creates the non-canonical URL, after which the scheme,
host, port and path of the URL are stored as separate members in 'parse'
using `ne_uri_parse()'.
> If the former, we should look for all other uses of ne_uri_parse() and
> canonicalize after them as well. If the latter, we should fix the
> do_checkout() function and look for all other uses of
> svn_ra_neon__request_get_location().
Does this imply to make `svn_ra_neon__request_get_location()' create a
non-canonical URL by default?
> (What does the non-canonical URL or URI look like?)
http://localhost/repos/devrepo/!svn/wrk/b4ec0dff-9abf-42ee-8860-a6a9630218e4/
(which is generated by do_checkout() and parse.path value would be:
/repos/devrepo/!svn/wrk/b4ec0dff-9abf-42ee-8860-a6a9630218e4/ )
- --
Thanks & Regards,
Kannan
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/
iQEVAwUBSzCpunlTqcY7ytmIAQIu5Qf+ImE68BJEJ2nOxMzpo0s/bfR8wE2QORip
F9PK1rkZTPMwYAS5aLnkTgnXFu2wtfk8ZGEHdbEaQYoieQ4VypqKjQ1OPhAVY2K9
JUsCtDzrbUDtBbp/wXZptiCbnoxRFty2nSahNBcz0A+yS9Naxqx2mbfM9HW06v5C
72u65407Q6lXFPSzG1/QVLFuNSQseQkmZXzesHnnbfij5CGUa8xYwYLU7sX5OzHM
P+YQqQrFDLgL2dlU2NeWvJxWPookOklNaC/vMhndFWfqwvcMU9VWOl5kHP4CX3Fp
LveUAMN70XhHOkQ/ILRDINYUY2ev0E30OGnxrYbhJ7tv/UBr60Bxwg==
=C9YY
-----END PGP SIGNATURE-----
Received on 2009-12-22 12:18:13 CET