Re: [PATCH] Allow to build with full path to neon-config.

2009-12-14 18:56:50 Philip Martin napisał(a):
> Alexander Thomas <alexander_at_collab.net> writes:
>
> > On Mon, 2009-12-14 at 13:47 +0000, Philip Martin wrote:
> >> Alexander Thomas <alexander_at_collab.net> writes:
> >>
> >> > [[[
> >> > Allow build against the full path to neon-config.
> >> >
> >> > * build/ac-macros/neon.m4
> >> > (SVN_LIB_NEON): Modified to accept full path to neon-config. Fixed doc
> >> > string accordingly.
> >> > ]]]
> >>
> >> What's the rationale for this change? Does it fix something?
> >>
> > This don't fix anything. I'm only trying to make --with-neon option
> > consistent with other options like --with-apr/apu, which already
> > supports a full path to respective *-config files. So why not we do the
> > same with neon ?
>
> The apr[-util] location stuff is copied from those projects. The
> Subversion stuff tends to behave like --with-neon, look at --with-swig
> and --with-gssapi. It doesn't seem like an important thing to change,
> and like any build change it risks breaking obscure platforms. You
> are using "test -x" and I see that find_apr.m4 explicitly avoids that
> on OS/2.

I agree that this change isn't needed.
Additionally a part of the patch is incorrect.

$ test -x /usr ; echo $?
0

-- 
Arfrever Frehtes Taifersar Arahesis