[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH v2] Issue #3390 Relative externals not updated during switch

From: Daniel Näslund <daniel_at_longitudo.com>
Date: Fri, 11 Dec 2009 22:34:37 +0100

On Fri, Dec 11, 2009 at 04:51:31PM +0100, Daniel Näslund wrote:
> Hi!
>
> make check passed.
>
> [[[
> Fix issue #3390, relative externals not updated during switch.
>
> * subversion/libsvn_client/switch.c
> (svn_client__switch_internal): Pass in an external_func to
> svn_wc_crawl_revision5().
>
> * subversion/libsvn_client/externals.c
> (handle_externals_desc_change): Get the url for parent_dir with
> svn_wc__node_get_url(). Does not work for export where the
> parent_dir has no url. Then we resort to the old way of adding the
> parent_dir to the from_url.
>
> * subversion/tests/cmdline/externals_tests.py
> (test_list): Remove XFail from switch_relative_external.
>
> Patch by: Daniel Näslund <daniel{_AT_}longitudo.com>
> ]]]
 
Removed two debugging variables left in the code.

> When running the update_editor all externals that have changed is
> recorded. But in a switch we need to change all relative externals. So I
> added an external_func to collect those.

What I meant here was that only the svn:externals that have changed are
recorded, but we need to change the relative externals even if they
haven't changed.

[...]

/Daniel

Received on 2009-12-11 22:35:21 CET

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.